Skip to content

Conversation

@ShadowCurse
Copy link
Contributor

Changes

  • Enabled topology tests for aarch64
  • Added hwloc topology tests

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse added the Type: Enhancement Indicates new feature requests label May 15, 2023
@ShadowCurse ShadowCurse self-assigned this May 15, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.82%. Comparing base (b7d041f) to head (50f89f0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3686   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         269      269           
  Lines       27747    27747           
=======================================
+ Hits        22981    22982    +1     
+ Misses       4766     4765    -1     
Flag Coverage Δ
5.10-m5n.metal 83.00% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.25% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.65% <ø> (ø)
5.10-m6i.metal 82.99% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.25% <ø> (ø)
5.10-m7g.metal 79.65% <ø> (ø)
5.10-m7i.metal-24xl 82.96% <ø> (ø)
5.10-m7i.metal-48xl 82.96% <ø> (-0.01%) ⬇️
5.10-m8g.metal-24xl 79.65% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 79.65% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.02% <ø> (ø)
6.1-m6a.metal 82.29% <ø> (ø)
6.1-m6g.metal 79.65% <ø> (ø)
6.1-m6i.metal 83.01% <ø> (ø)
6.1-m7a.metal-48xl 82.27% <ø> (ø)
6.1-m7g.metal 79.65% <ø> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.03% <ø> (ø)
6.1-m7i.metal-48xl 83.03% <ø> (-0.01%) ⬇️
6.1-m8g.metal-24xl 79.65% <ø> (-0.01%) ⬇️
6.1-m8g.metal-48xl 79.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShadowCurse ShadowCurse force-pushed the hwlock_tests branch 2 times, most recently from 214aa14 to ef88741 Compare October 23, 2025 08:56
- Enabled topology tests for aarch64
- Added hwloc topology tests

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse changed the title Update of cpu topology tests Add hwlic-info cpu tolopogy tests Oct 23, 2025
@ShadowCurse ShadowCurse marked this pull request as ready for review October 23, 2025 11:09
@ShadowCurse ShadowCurse added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 23, 2025
@Manciukic Manciukic merged commit 203091e into firecracker-microvm:main Oct 27, 2025
8 checks passed
@ShadowCurse ShadowCurse deleted the hwlock_tests branch October 31, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Enhancement Indicates new feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants